AndSMB 1.5: File count wrong when downloading

Samba/CIFS client for android.

AndSMB 1.5: File count wrong when downloading

Postby zippanova » Thu Aug 04, 2011 7:49 pm

The "files left" count displays an incorrect number when downloading multiple files. This seems to occur when moving a folder of files, or a folder of folders of files (probably all cases similar to this).

The number appears to be calculated as follows. For this sample directory structure:
D = directory
F = file

D-\
|-D-\
| |-F
| \-F
\-F
D-\
|-F
\-F


When trying to copy both of the top level directories, I would expect the remaining file count to start at 4 (5 files minus the current transferring file). The observed behaviour is the file count starts at 1 (2 top-level directories selected minus the current transferring file).

I hope this is clear enough to address the issue.

~Alex
zippanova
 
Posts: 4
Joined: Wed Aug 03, 2011 3:47 pm

Re: AndSMB 1.5: File count wrong when downloading

Postby support » Sat Aug 06, 2011 10:14 am

Problem is that directory is not recursed so all files in a remote directory = 1
support
 
Posts: 1021
Joined: Sun Apr 20, 2008 4:40 pm

Re: AndSMB 1.5: File count wrong when downloading

Postby zippanova » Mon Aug 08, 2011 4:37 pm

Sounds like the problem has been identified well. When is a release planned with a fix?

Cheers,
~Alex
zippanova
 
Posts: 4
Joined: Wed Aug 03, 2011 3:47 pm

Re: AndSMB 1.5: File count wrong when downloading

Postby support » Mon Aug 08, 2011 8:36 pm

I think it will be an option because it requires to count remote file before downloading and it could take a while before starting transfer (depending on how many remote files/folders/subfolders)
support
 
Posts: 1021
Joined: Sun Apr 20, 2008 4:40 pm

Re: AndSMB 1.5: File count wrong when downloading

Postby zippanova » Tue Aug 09, 2011 4:49 pm

Would it really take that much longer to query only the selected directory? That seems like it would add a very small amount of the total time to the transfer. If there are more files to list, the transfer is still going to take longer anyway. Also, if you were to make the correct file counting behaviour an option, when the option is disabled you might as well just remove the file count, since it is most likely wrong in that case.
zippanova
 
Posts: 4
Joined: Wed Aug 03, 2011 3:47 pm


Return to AndSMB



cron

Sitemap | Privacy Statement | Java and all Java-based marks are trademarks or registered trademarks of Sun Microsystems, Inc.
in the U.S. and other countries. All other company and/or product names are the property of their respective owners.